Skip to content

Add Deno hook language support #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GruffElixir wants to merge 1 commit into from
+88 −0
Closed

Add Deno hook language support #3756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pre_commit/all_languages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from pre_commit.languages import conda
from pre_commit.languages import coursier
from pre_commit.languages import dart
from pre_commit.languages import deno
from pre_commit.languages import docker
from pre_commit.languages import docker_image
from pre_commit.languages import dotnet
Expand All @@ -28,6 +29,7 @@
'conda': conda,
'coursier': coursier,
'dart': dart,
'deno': deno,
'docker': docker,
'docker_image': docker_image,
'dotnet': dotnet,
Expand Down
39 changes: 39 additions & 0 deletions pre_commit/languages/deno.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
from __future__ import annotations

from collections.abc import Sequence

from pre_commit import lang_base
from pre_commit.prefix import Prefix
from pre_commit.util import cmd_output_b

ENVIRONMENT_DIR = None
get_default_version = lang_base.basic_get_default_version
install_environment = lang_base.no_install
in_env = lang_base.no_env


def health_check(prefix: Prefix, version: str) -> str | None:
retcode, _, _ = cmd_output_b('deno', '--version', check=False)
if retcode != 0:
return f'`deno --version` returned {retcode}'
else:
return None


def run_hook(
prefix: Prefix,
entry: str,
args: Sequence[str],
file_args: Sequence[str],
*,
is_local: bool,
require_serial: bool,
color: bool,
) -> tuple[int, bytes]:
cmd = ('deno', *lang_base.hook_cmd(entry, args))
return lang_base.run_xargs(
cmd,
file_args,
require_serial=require_serial,
color=color,
)
47 changes: 47 additions & 0 deletions tests/languages/deno_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
from __future__ import annotations

from unittest import mock

from pre_commit.languages import deno
from pre_commit.prefix import Prefix


def test_deno_run_hook(tmp_path):
with mock.patch.object(
deno.lang_base, 'run_xargs', return_value=(0, b''),
) as run_xargs:
ret = deno.run_hook(
Prefix(str(tmp_path)),
'fmt --check',
('--unstable-sloppy-imports',),
('script.ts',),
is_local=False,
require_serial=True,
color=False,
)

assert ret == (0, b'')
run_xargs.assert_called_once_with(
('deno', 'fmt', '--check', '--unstable-sloppy-imports'),
('script.ts',),
require_serial=True,
color=False,
)


def test_deno_health_check(monkeypatch, tmp_path):
cmd_output = mock.Mock(return_value=(0, b'Deno 2.0.0', b''))
monkeypatch.setattr(deno, 'cmd_output_b', cmd_output)

assert deno.health_check(Prefix(str(tmp_path)), 'default') is None
cmd_output.assert_called_once_with('deno', '--version', check=False)


def test_deno_health_check_missing(monkeypatch, tmp_path):
monkeypatch.setattr(
deno, 'cmd_output_b', lambda *args, **kwargs: (127, b'', b''),
)

assert deno.health_check(
Prefix(str(tmp_path)), 'default',
) == '`deno --version` returned 127'
Loading