Conversation
git's pre-push protocol emits 64-zero oids on sha256 repos. the hardcoded Z40 check missed deletions so `git push --delete` failed with an invalid revision range. Fixes pre-commit#3664 Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3664
pre-push only treated
0*40 as the zero oid. SHA-256 repos send 64 zeros, sogit push --deletefell through togit diffand died on an invalid revision range.Treat both 40-zero and 64-zero oids as the zero sha. Tests cover both lengths.