Skip to content

Don't use identify if not necessary #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vries wants to merge 2 commits into from
+19 −0
Closed

Don't use identify if not necessary #3725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24b133a
Add test_classifier_no_types
vries Jul 21, 2026
e6578a9
Don't use identify if not necessary
vries Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pre_commit/commands/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ def by_types(
types = frozenset(types)
types_or = frozenset(types_or)
exclude_types = frozenset(exclude_types)
if not types and not types_or and not exclude_types:
# We're not filtering on types, just return all filenames.
for filename in names:
yield filename
return
for filename in names:
tags = self._types_for_file(filename)
if (
Expand Down
14 changes: 14 additions & 0 deletions tests/commands/run_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,6 +1160,20 @@ def test_classifier_empty_types_or(tmpdir):
assert tuple(for_file) == ('bar',)


def test_classifier_no_types(tmpdir):
tmpdir.join('bar').ensure()
os.symlink(tmpdir.join('bar'), tmpdir.join('foo'))
with tmpdir.as_cwd():
classifier = Classifier(('foo', 'bar'))
res = classifier.by_types(
classifier.filenames,
types=[],
types_or=[],
exclude_types=[],
)
assert tuple(res) == ('foo', 'bar')


@pytest.fixture
def some_filenames():
return (
Expand Down
Loading