Don't use identify if not necessary#3725
Closed
vries wants to merge 2 commits into
Closed
Conversation
Add a test in tests/commands/run_test.py to check the case that types, types_or and exclude_types are all empty.
If types, types_or and exclude_types are all empty, there's no need to call identify.
Member
|
seems like unnecessary complexity and unlikely to improve anything. please start with an issue explaining next time |
Author
I've filed an issue ( #3729 ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we're not filtering on types, there's no need to call identify.