Add --quiet / -q flag to suppress output for passing and skipped hooks#3675
Closed
nitzan-shaked wants to merge 1 commit into
Closed
Add --quiet / -q flag to suppress output for passing and skipped hooks#3675nitzan-shaked wants to merge 1 commit into
nitzan-shaked wants to merge 1 commit into
Conversation
In quiet mode, per-hook output is suppressed for hooks that pass or are skipped (both SKIP= and no-files-to-check variants). Failed hooks still print their full output. Verbose detail lines (hook id, duration) are also suppressed for passing hooks when --quiet is set. Fixes pre-commit#823.
Member
|
ai slop is not acceptable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #823.
Summary
This adds a
--quiet/-qflag topre-commit run(andtry-repo, which shares the same arg parser). In quiet mode:SKIP=and no-files-to-check variants).- hook id:,- duration:) are also suppressed for passing hooks when--quietis set.This is the minimal implementation discussed in the issue. The goal is to reduce noise in large monorepos where dozens of hooks are skipped on every commit.
Changes
pre_commit/main.py--quiet/-qarg to_add_run_options()pre_commit/commands/run.pyquietthrough_run_single_hook(); suppress output for non-failing hookspre_commit/commands/hook_impl.pyquiet=Falseto the_ns()Namespace so the git-hook code path doesn't crashtesting/util.pyquiet=Falsetorun_opts()helpertests/commands/run_test.pyTest plan