Skip to content

fix: uninstall without -t removes all pre-commit managed hooks #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tiryoh wants to merge 1 commit into from
+29 −1
Closed

fix: uninstall without -t removes all pre-commit managed hooks #3633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pre_commit/commands/install_uninstall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

from pre_commit import git
from pre_commit import output
from pre_commit.clientlib import HOOK_TYPES
from pre_commit.clientlib import InvalidConfigError
from pre_commit.clientlib import load_config
from pre_commit.repository import all_hooks
Expand Down Expand Up @@ -162,6 +163,10 @@ def _uninstall_hook_script(hook_type: str) -> None:


def uninstall(config_file: str, hook_types: list[str] | None) -> int:
for hook_type in _hook_types(config_file, hook_types):
if hook_types is not None:
actual_hook_types = hook_types
else:
actual_hook_types = list(HOOK_TYPES)
for hook_type in actual_hook_types:
_uninstall_hook_script(hook_type)
return 0
23 changes: 23 additions & 0 deletions tests/commands/install_uninstall_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,3 +1102,26 @@ def test_install_uninstall_default_hook_types(in_git_dir, store):
assert not uninstall(C.CONFIG_FILE, hook_types=None)
assert not in_git_dir.join('.git/hooks/pre-commit').exists()
assert not in_git_dir.join('.git/hooks/pre-push').exists()


def test_uninstall_without_t_removes_all_hooks(in_git_dir, store):
install(C.CONFIG_FILE, store, hook_types=['pre-commit'])
install(C.CONFIG_FILE, store, hook_types=['pre-push'])
assert in_git_dir.join('.git/hooks/pre-commit').exists()
assert in_git_dir.join('.git/hooks/pre-push').exists()

assert not uninstall(C.CONFIG_FILE, hook_types=None)
assert not in_git_dir.join('.git/hooks/pre-commit').exists()
assert not in_git_dir.join('.git/hooks/pre-push').exists()


def test_uninstall_without_t_ignores_non_precommit_hooks(in_git_dir, store):
install(C.CONFIG_FILE, store, hook_types=['pre-commit'])
# write a non-pre-commit hook
in_git_dir.join('.git/hooks/pre-push').write('#!/bin/sh\necho custom\n')
assert in_git_dir.join('.git/hooks/pre-push').exists()

assert not uninstall(C.CONFIG_FILE, hook_types=None)
assert not in_git_dir.join('.git/hooks/pre-commit').exists()
# non-pre-commit hook should be preserved
assert in_git_dir.join('.git/hooks/pre-push').exists()
Loading