Skip to content

feature: fetch tag pointing to HEAD in shallow clone #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnought wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: fetch tag pointing to HEAD in shallow clone #3617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions pre_commit/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from pre_commit import git
from pre_commit.util import CalledProcessError
from pre_commit.util import clean_path_on_failure
from pre_commit.util import cmd_output_b
from pre_commit.util import cmd_output
from pre_commit.util import resource_text


Expand Down Expand Up @@ -174,19 +174,32 @@ def _get_result() -> str | None:

return directory

def _complete_clone(self, ref: str, git_cmd: Callable[..., None]) -> None:
def _complete_clone(
self, ref: str,
git_cmd: Callable[..., tuple[int, str, str | None]],
) -> None:
"""Perform a complete clone of a repository and its submodules """

git_cmd('fetch', 'origin', '--tags')
git_cmd('checkout', ref)
git_cmd('submodule', 'update', '--init', '--recursive')

def _shallow_clone(self, ref: str, git_cmd: Callable[..., None]) -> None:
def _shallow_clone(
self, ref: str,
git_cmd: Callable[..., tuple[int, str, str | None]],
) -> None:
"""Perform a shallow clone of a repository and its submodules """

git_config = 'protocol.version=2'
git_cmd('-c', git_config, 'fetch', 'origin', ref, '--depth=1')
git_cmd('checkout', 'FETCH_HEAD')
rev = git_cmd('rev-parse', 'FETCH_HEAD')[1].strip()
lines = git_cmd('ls-remote', '--heads', 'origin')[1].splitlines()
for line in lines:
if line.startswith(rev):
tag_name = line.rsplit('/', 1)[-1]
git_cmd('fetch', 'origin', 'tag', tag_name, '--no-tags')
break
git_cmd(
'-c', git_config, 'submodule', 'update', '--init', '--recursive',
'--depth=1',
Expand All @@ -199,8 +212,8 @@ def clone_strategy(directory: str) -> None:
git.init_repo(directory, repo)
env = git.no_git_env()

def _git_cmd(*args: str) -> None:
cmd_output_b('git', *args, cwd=directory, env=env)
def _git_cmd(*args: str) -> tuple[int, str, str | None]:
return cmd_output('git', *args, cwd=directory, env=env)

try:
self._shallow_clone(ref, _git_cmd)
Expand Down
Loading