Skip to content

prefer sys.platform over os.name when checking for windows OS #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asottile merged 1 commit into from
Mar 4, 2023
Merged

prefer sys.platform over os.name when checking for windows OS #2796

asottile merged 1 commit into from
Mar 4, 2023

Conversation

@m-rsha
Copy link
Contributor

@m-rsha m-rsha commented Mar 4, 2023

No description provided.

@m-rsha m-rsha marked this pull request as ready for review March 4, 2023 02:28
asottile
asottile reviewed Mar 4, 2023
View reviewed changes
asottile
asottile approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 321685e into pre-commit:main Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m-rsha @asottile