Skip to content

speed up ruby tests by picking a prebuilt in 22.04 #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asottile merged 1 commit into from
Jan 29, 2023
Merged

speed up ruby tests by picking a prebuilt in 22.04 #2726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/resources/ruby_versioned_hooks_repo/.pre-commit-hooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
name: Ruby Hook
entry: ruby_hook
language: ruby
language_version: 3.1.0
language_version: 3.2.0
files: \.rb$
4 changes: 2 additions & 2 deletions tests/languages/ruby_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ def test_install_ruby_default(fake_gem_prefix):

@xfailif_windows # pragma: win32 no cover
def test_install_ruby_with_version(fake_gem_prefix):
ruby.install_environment(fake_gem_prefix, '3.1.0', ())
ruby.install_environment(fake_gem_prefix, '3.2.0', ())

# Should be able to activate and use rbenv install
with ruby.in_env(fake_gem_prefix, '3.1.0'):
with ruby.in_env(fake_gem_prefix, '3.2.0'):
cmd_output('rbenv', 'install', '--help')


Expand Down
4 changes: 2 additions & 2 deletions tests/repository_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def test_run_versioned_ruby_hook(tempdir_factory, store):
tempdir_factory, store, 'ruby_versioned_hooks_repo',
'ruby_hook',
[os.devnull],
b'3.1.0\nHello world from a ruby hook\n',
b'3.2.0\nHello world from a ruby hook\n',
)


Expand All @@ -269,7 +269,7 @@ def test_run_ruby_hook_with_disable_shared_gems(
tempdir_factory, store, 'ruby_versioned_hooks_repo',
'ruby_hook',
[os.devnull],
b'3.1.0\nHello world from a ruby hook\n',
b'3.2.0\nHello world from a ruby hook\n',
)


Expand Down