Fix command normalization when a custom env is passed #2677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Jan 5, 2023
pre_commit/parse_shebang.py
Outdated
|
|
||
| def find_executable( | ||
| exe: str, _environ: Mapping[str, str] | None = None, | ||
| exe: str, *, _environ: Mapping[str, str] | None = None, |
Member
There was a problem hiding this comment.
if it's public it shouldn't be underscored. env is probably what it sounds be called to match subprocess
taoufik07
force-pushed
the
fix_cmd_norm_env
branch
2 times, most recently
from
411ef96 to
338de08
Compare
asottile
reviewed
Jan 5, 2023
| homedir = tempdir_factory.get() | ||
| ret, out = git_commit( | ||
| env={ | ||
| **os.environ, |
Member
There was a problem hiding this comment.
hmmm why did this need to change?
Contributor
Author
There was a problem hiding this comment.
It was missing PATHEXT for windows so it couldn't find git. I pushed the right change, it should be good now.
taoufik07
force-pushed
the
fix_cmd_norm_env
branch
3 times, most recently
from
f7fecc1 to
ada060c
Compare
asottile
force-pushed
the
fix_cmd_norm_env
branch
from
ada060c to
bf1a1fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom envs can't be passed to
normalize_cmdwhich causesfind_executableto default toos.environ-- works as expected when injecting directlyos.environ.