Skip to content

Remove defaults from pre-commit config schema. Resolves #227 - #231

Merged
asottile merged 1 commit into
masterfrom
no_defaults_in_config_227
May 18, 2015
Merged

asottile merged 1 commit into
masterfrom
no_defaults_in_config_227

Conversation

@asottile

Copy link
Copy Markdown
Member

No description provided.

@asottile
asottile force-pushed the no_defaults_in_config_227 branch from 843155a to b140f92 Compare May 18, 2015 19:55
@asottile

Copy link
Copy Markdown
Member Author

@Lucas-C look correct?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 99.96% when pulling b140f92 on no_defaults_in_config_227 into 9515ca0 on master.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to default to '^$' here ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it doesn't matter, as long as the fallback value is a valid regex (since this is just the checking code)

@asottile
asottile force-pushed the no_defaults_in_config_227 branch from b140f92 to 039a7a5 Compare May 18, 2015 20:59
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 039a7a5 on no_defaults_in_config_227 into 9515ca0 on master.

asottile added a commit that referenced this pull request May 18, 2015
Remove defaults from pre-commit config schema.  Resolves #227
@asottile
asottile merged commit 483c4a3 into master May 18, 2015
@asottile
asottile deleted the no_defaults_in_config_227 branch May 18, 2015 22:14
@asottile

Copy link
Copy Markdown
Member Author

This has been released as part of 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants