Skip to content

--allow-unstaged-config arg - #225

Merged
asottile merged 2 commits into
pre-commit:masterfrom
caffodian:master
May 10, 2015
Merged

asottile merged 2 commits into
pre-commit:masterfrom
caffodian:master

Conversation

@caffodian

Copy link
Copy Markdown
Contributor

Change the behaviour for unstaged config per #157 discussion

  • if allow unstaged config, puts a warning message that the config will still be stashed, but continues
  • if not provided, errors out

stuff I'd expect we might want to change would be the actual content of the messages and perhaps what the "default" is here.

thanks for the support! @asottile

@caffodian

Copy link
Copy Markdown
Contributor Author

Ha. Ironically, I somehow missed actually running the hooks on one of the files while messing about :p should be resolved now.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling c99b333 on caffodian:master into d97ea30 on pre-commit:master.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make --no-stash silence both of these errors

@asottile

asottile commented May 8, 2015

Copy link
Copy Markdown
Member

Overall looks great! Fix up those few little things, squash the commits and I'll merge it \o/

@caffodian

Copy link
Copy Markdown
Contributor Author

fixed and squashed. not sure if appveyor is just going nuts because of the squash or...

@asottile

Copy link
Copy Markdown
Member

Appveyor seems to be mad because it merge-conflicts with master now

Conflicts:
	tests/commands/run_test.py
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 1c28ae1 on caffodian:master into 24ce081 on pre-commit:master.

asottile added a commit that referenced this pull request May 10, 2015
--allow-unstaged-config arg
@asottile
asottile merged commit e094589 into pre-commit:master May 10, 2015
@asottile

Copy link
Copy Markdown
Member

👍 Thanks for the contribution! Please PR http://github.com/pre-commit/pre-commit.github.io to add yourself :D

@asottile

Copy link
Copy Markdown
Member

This has been released as part of 0.5.0

droctothorpe pushed a commit to droctothorpe/pre-commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants