added warning if mutable rev is used #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Nov 26, 2020
asottile
reviewed
Nov 30, 2020
asottile
reviewed
Dec 3, 2020
asottile
reviewed
Dec 7, 2020
This was referenced Mar 8, 2021
Closed
This was referenced Mar 10, 2021
y-yagi
added a commit
to y-yagi/pre-commit-golang
that referenced
this pull request
Mar 29, 2021
`pre-commit` don't recommend to use a mutable reference to `rev` and now shows a warning when `rev` is a mutable reference. Ref: pre-commit/pre-commit#1715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #974
MigrateShaToRev-class, but i think it's better to keep them separatedHEAD, this is sufficient imo, but i can also change it so it tests for all mutable revs defined in{'HEAD', 'stable', 'master'}