Skip to content

Use virtualenv python from install-time for less virtualenv requirements at commit time.#166

Merged
struys merged 1 commit into
masterfrom
venv_python
Sep 4, 2014
Merged

Use virtualenv python from install-time for less virtualenv requirements at commit time.#166
struys merged 1 commit into
masterfrom
venv_python

Conversation

@asottile

@asottile asottile commented Sep 4, 2014

Copy link
Copy Markdown
Member

This enables the following workflow:

$ sh -c '. venv/bin/activate && pre-commit install'
$ git commit -m ...

which previously would have needed to have been:

$ sh -c '. venv/bin/activate && pre-commit install'
$ . venv/bin/activate
$ git commit -m ...

Closes #164

@coveralls

coveralls commented Sep 4, 2014

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 812fcc4 on venv_python into 59e7536 on master.

struys
struys reviewed Sep 4, 2014
View reviewed changes
Comment thread pre_commit/commands/install_uninstall.py Outdated

@struys struys Sep 4, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a tuple

@coveralls

coveralls commented Sep 4, 2014

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 598e546 on venv_python into a6112f4 on master.

struys added a commit that referenced this pull request Sep 4, 2014
@struys
Merge pull request #166 from pre-commit/venv_python
b089c74 
Use virtualenv python from install-time for less virtualenv requirements at commit time.
@struys
struys merged commit b089c74 into master Sep 4, 2014
@struys
struys deleted the venv_python branch September 4, 2014 21:48
@cjolowicz cjolowicz mentioned this pull request Jun 29, 2020
Closed
droctothorpe pushed a commit to droctothorpe/pre-commit that referenced this pull request Mar 23, 2022
@asottile
Merge pull request pre-commit#166 from pre-commit/pre_commit_hooks_yaml
2df9948 
Add .pre-commit-hooks.yaml for forward compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Choose python more intelligently in the file installed to .git/hooks/pre-commit

3 participants

@asottile @coveralls @struys