Skip to content

check cygwin mismatch earlier#1606

Merged
asottile merged 1 commit intomasterfrom
move_cygwin_mismatch
Sep 20, 2020
Merged

check cygwin mismatch earlier#1606
asottile merged 1 commit intomasterfrom
move_cygwin_mismatch

Conversation

@asottile
Copy link
Copy Markdown
Member

resolves #1605

@danyeaw
Copy link
Copy Markdown

danyeaw commented Sep 20, 2020

@asottile I tried this out, and it does move the cygwin mismatch check up earlier. I don't think it fixes the issue though, it isn't that I am missing the error because of the other issues, the problem is that I shouldn't be getting this warning at all. I am not running in cygwin, I am in MSYS2 and my git and Python aren't mismatched.

@asottile
Copy link
Copy Markdown
Member Author

they are mismatched, one is acting like windows and the other is acting like posix -- that's the entire point of the warning

@asottile asottile force-pushed the move_cygwin_mismatch branch from c87d534 to 91530f1 Compare September 20, 2020 17:42
@asottile asottile merged commit f13dcac into master Sep 20, 2020
@asottile asottile deleted the move_cygwin_mismatch branch September 20, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for MSYS2 in Windows

2 participants