fix hooks firing during staged_files_only #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Running |
asottile
reviewed
Apr 30, 2020
Contributor
Author
|
I've pushed the changes - I started adding a test case for this, but it's a bit beyond my python skill level I'm afraid. |
asottile
reviewed
Apr 30, 2020
Member
|
needs a test as well |
Contributor
Author
As I said, I'm trying to help without really knowing python - the tests are particularly hard to pick apart. |
Member
|
oh ok, I can help wiht the test |
asottile
changed the title
asottile
changed the title
Contributor
Author
|
Great cat, thanks for your help! |
Member
|
thanks again for the fix and report, this has been released as part of v2.4.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass through an environment variable to prevent hooks running
Fixes #1418.