Don't use --user when running docker on windows - #1371

can you show a failure mode? usually it doesn't matter if there's a user with that uid inside

also it's "docker" ;)

Wow, you reviewed fast... Let me fix some pre-commit issue and also address your comments! @asottile

can you show a failure mode? usually it doesn't matter if there's a user with that uid inside

We have a docker image in which we pre-define some git configuration. It's been persisted in /root/.gitconfig. When running with a different or non-existed user such as 1000, he won't be able to retrieve these pre-defined value.

@asottile comments addressed, build has passed! Ready for another look. Thank you!

We have a docker image in which we pre-define some git configuration. It's been persisted in /root/.gitconfig. When running with a different or non-existed user such as 1000, he won't be able to retrieve these pre-defined value.

I don't think that this fixes that then, since the current user will still be used on POSIX platforms

you could instead put your in-container configuration at /etc/gitconfig and then you don't need to worry about the user

you could instead put your in-container configuration at /etc/gitconfig and then you don't need to worry about the user

You are correct. I'm able to mess around with /etc/gitconfig to persist that config at system level instead of user level.

OTOH, I still think it would be useful to accept the change in this PR. We can avoid using an imaginary user (1000) when running docker on Windows. What do you think? @asottile

I'm torn because the current code "works", this change just makes it different 🤔