Skip to content

Handle case when executable is not executable - #1161

Merged
asottile merged 1 commit into
pre-commit:masterfrom
WillKoehrsen:not-executable-fix
Oct 7, 2019
Merged

asottile merged 1 commit into
pre-commit:masterfrom
WillKoehrsen:not-executable-fix

Conversation

@WillKoehrsen

Copy link
Copy Markdown
Contributor
  • Changed error message if executable is not executable

Closes:1159

Comment thread pre_commit/parse_shebang.py Resolved
@WillKoehrsen
WillKoehrsen force-pushed the not-executable-fix branch 2 times, most recently from fb60c59 to 80cd2c3 Compare October 7, 2019 16:21
Comment thread tests/parse_shebang_test.py Resolved
Comment thread tests/parse_shebang_test.py Resolved
Comment thread tests/parse_shebang_test.py Resolved
Comment thread tests/parse_shebang_test.py Resolved
@WillKoehrsen
WillKoehrsen force-pushed the not-executable-fix branch 5 times, most recently from d43c4db to ae14708 Compare October 7, 2019 18:09
Comment thread tests/parse_shebang_test.py Resolved
@WillKoehrsen
WillKoehrsen force-pushed the not-executable-fix branch 2 times, most recently from 1c98eef to 47387ce Compare October 7, 2019 19:12

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread tests/parse_shebang_test.py Resolved
- Changed error message if executable is not executable

Closes:[1159](pre-commit#1159)
@WillKoehrsen

Copy link
Copy Markdown
Contributor Author

@asottile Thanks for coaching me through this one! 👍

@asottile

asottile commented Oct 7, 2019

Copy link
Copy Markdown
Member

@asottile Thanks for coaching me through this one! +1

happy to help! thanks for the contribution!

@asottile
asottile merged commit 183c8cb into pre-commit:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message when entry script is present but not executable

2 participants