Fix docker based hooks failing on Windows - #1094
Merged
Merged
Conversation
geieredgar
marked this pull request as ready for review
July 23, 2019 13:53
asottile
reviewed
Jul 24, 2019
asottile
left a comment
Member
There was a problem hiding this comment.
oh my, I forgot to press submit -- so sorry on the delay here
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1072
Docker for Windows
-valways usingroot:rootas owner, even if a-u UID:GIDoption is passedtouch) also useroot:rootas owner, even if the container is run as non-root userls -lyields-rwxr-x-r-xas file permissionsThis is because Docker for Windows currently implements host mounted volumes via SMB (see https://docs.docker.com/docker-for-windows/troubleshoot/#volumes), which handles the access to mounted files and does not allow changing permissions from inside the container (see docker/docs#3298).
Therefore the UID and GID we pass to docker can be chosen arbitrarily, because the owner of files on the host will match the Windows user running docker and not the user in the docker container.
There are also some other caveats when it comes to running linux docker images via Docker for Windows, e.g. you have to be careful about line endings (moby/moby#24388).
With these changes I was able to successfully run a hook on Windows using
language: docker_imagefor a personal project of mine, therefore I would like to see something like this getting merged.What are your thoughts about this?