Skip to content

Add warning to additional keys in config - #1028

Merged
asottile merged 4 commits into
pre-commit:masterfrom
yoavcaspi:warn_unknown_keys
May 12, 2019
Merged

asottile merged 4 commits into
pre-commit:masterfrom
yoavcaspi:warn_unknown_keys

Conversation

@yoavcaspi

Copy link
Copy Markdown
Contributor

Resolves #965

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also do one for the CONFIG_SCHEMA as well (the actual top-level)

Comment thread pre_commit/clientlib.py Resolved
Comment thread pre_commit/clientlib.py Resolved
Comment thread pre_commit/clientlib.py Resolved
@yoavcaspi

Copy link
Copy Markdown
Contributor Author

Let me know if there are other issues.

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Comment thread pre_commit/clientlib.py Resolved
@asottile
asottile merged commit e10b818 into pre-commit:master May 12, 2019
@asottile

Copy link
Copy Markdown
Member

Thanks again! And thanks to @mitzkia for the assist via cfgv!

@yoavcaspi
yoavcaspi deleted the warn_unknown_keys branch May 13, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

warn on unknown keys at the top level

2 participants