warn on unknown keys at the top level #965

Activity

1. asottile

   added

   feature

   good-first-issue

   on Mar 8, 2019
2. yoavcaspi commented on May 7, 2019

   

   yoavcaspi

   on May 7, 2019

   Contributor

   More actions

   I wish to work on this issue.
   I'm pre-commit newbie.
   can you refer me to the warning on unknown keys at the hook level?
3. asottile commented on May 7, 2019

   

   asottile

   on May 7, 2019

   MemberAuthor

   More actions

   sure! @mitzkia started some work on this in #980 and added a WarnAdditionalKeys helper to cfgv to make this easier to do -- but looks like they've been busy with other things :)

   the extraneous keys for the hook level is done later in the process here -- though for the top level and repository level this should probably get done in pre_commit/clientlib.py (on the two mapping types directly) via the new WarnAdditionalKeys

   👍React with 👍1Reacted by yoavcaspi
4. asottile

   closed this as completedin #1028on May 12, 2019