Incorrect shebang in .git/hooks/pre-commit for python3 only installations #878

Activity

1. asottile commented on Dec 4, 2018

   

   asottile

   on Dec 4, 2018

   Member

   More actions

   hmm! that's a good point I hadn't thought of but presents some issues I can think of:

   • windows (official python installs) always use python and not python3
   • INSTALL_PYTHON might be ephemeral, it's why there's three options for detecting pre-commit in the script

   that said, I think we can get this right, probably by inspecting sys.executable and determining what possible values could be used.
2. asottile

   added

   feature

   on Dec 4, 2018
3. asottile commented on Dec 4, 2018

   

   asottile

   on Dec 4, 2018

   Member

   More actions

   Maybe something like this?

   if sys.platform != 'win32' and six.PY3:
       return '#!/usr/bin/env python3'
   else:
       return '#!/usr/bin/env python'
4. fristedt commented on Dec 5, 2018

   

   fristedt

   on Dec 5, 2018

   Author

   More actions

   Maybe something like this?

   if sys.platform != 'win32' and six.PY3:
       return '#!/usr/bin/env python3'
   else:
       return '#!/usr/bin/env python'

   Thanks for the quick reply! I believe that would solve my problem.
5. asottile commented on Dec 10, 2018

   

   asottile

   on Dec 10, 2018

   Member

   More actions

   hmmm I just thought of another case while working on this that might not work. Some distributions (for instance arch) install python 3.x as /usr/bin/python and won't (?) necessarily have a /usr/bin/python3 executable

   I'll have to think about this some more -- maybe inspecting sys.executable is necessary. Maybe something like this
6. asottile commented on Dec 25, 2018

   

   asottile

   on Dec 25, 2018

   Member

   More actions

   @fristedt can you try out the branch in #893?
7. asottile

   closed this as completedin #893on Dec 26, 2018
8. fristedt commented on Jan 2, 2019

   

   fristedt

   on Jan 2, 2019

   Author

   More actions

   @fristedt can you try out the branch in #893?

   Tested, it works. Thanks @asottile!
9. asottile commented on Jan 8, 2019

   

   asottile

   on Jan 8, 2019

   Member

   More actions

   This has been released as part of v1.14.0 🎉 -- thanks again!