Skip to content

Document what pre-commit considers a mutable reference to be, or tweak the definition #3073

@alexpdp7

Description

@alexpdp7

search you tried in the issue tracker

"mutable"; I reviewed all matching issue subjects updated after #1715

describe your actual problem

We had some unexpected warnings running pre-commit, because one of our hooks repository uses the following tagging scheme for versions; yyyymmdd, but yyyymmdd.n if we make multiple releases on the same day.

Tags with .n work well, but tags without .n generate a warning- which we discovered when we found #1715 , and I just read the discussion on #1794.

IMHO, at least it would be good to document this behavior outside the source code. Either the message error can be expanded to describe the regex used, or the docs.

I am not sure the regex approach is ideal. So maybe "we may revisit if this comes up more frequently"...?

pre-commit --version

3.0.4

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions