Repository navigation
Misleading error message when entry script is present but not executable #1159
Description
Hi! I'm getting acquainted with pre-commit (I love it by the way). I tried adding a prepare-commit-msg script with
- repo: local
hooks:
- id: some-id
name: Some Name
stages: [prepare-commit-msg]
entry: ./bin/prepare-commit-msg.sh
language: scriptAt first I neglected to chmod +x bin/prepare-commit-msg.sh, so when I tried it out, I got the message
Executable `[path]/bin/prepare-commit-msg.sh` not found
The file was present, it just wasn't marked executable. I squinted for a short while looking for a typo somewhere before realizing my mistake.
Activity
asottile commentedon Oct 6, 2019
would you like to submit a PR for this? it should be an easy patch + test for this function here:
pre-commit/pre_commit/parse_shebang.py
Lines 54 to 55 in ab06397
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable
Handle case when executable is not executable