Skip to content

Allow action user to use custom commit message - #37

Closed
aaronmak wants to merge 1 commit into
pre-commit:masterfrom
aaronmak:master
Closed

Allow action user to use custom commit message#37
aaronmak wants to merge 1 commit into
pre-commit:masterfrom
aaronmak:master

Conversation

@aaronmak

@aaronmak aaronmak commented Jul 1, 2020

Copy link
Copy Markdown

In my case, I might need to include a prefix or I might want a different commit message than the default. And my guess is that others might find that useful as well.

@asottile

asottile commented Jul 1, 2020

Copy link
Copy Markdown
Member

hmmm I think I'd rather not make this an option such that it can be kept uniform / searchable -- I'm open to improving the current commit message though (I think it is much too terse)

@aaronmak

aaronmak commented Jul 3, 2020

Copy link
Copy Markdown
Author

how about a prefix then? I'm trying to use it for work but it requires some sort of prefix for JIRA tickets

@estahn

estahn commented Nov 23, 2020

Copy link
Copy Markdown

...that it can be kept uniform / searchable

@asottile Can you expand on your reasoning behind this? In our case, we're squashing the PR anyways hence it would just follow in line with the commit format (conventional commits) we have chosen.

There is always git commit --amend -m "an updated commit message" I suppose ;)

@henryiii

henryiii commented May 4, 2021

Copy link
Copy Markdown

This is now implemented in pre-commit.ci https://pre-commit.ci/#configuration-autoupdate_commit_msg :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants