#82: regex-only escape not supported in re fallback module - #83
#82: regex-only escape not supported in re fallback module#83fireundubh wants to merge 1 commit into
Conversation
Fixed issue where custom abbreviations test failed due to permission error
|
Excellent work, @fireundubh, thank you! The current tests do include examples with Unicode characters (#46 added the examples suggested in #33 where this was originally raised). Play devil's advocate, would we be better off keeping the package's logic the same in the cases where I've added #84 which adds a simple GitHub Actions workflow to set up automated running of the tests using a configuration without |
|
This PR is now superseded by #84, with all credit to @fireundubh. |
|
Closing in favor of #84. |
3 participants
Addressing #82:
regex-only changes to regular expressionsAll current tests pass. Whether existing tests cover the Unicode issues that the
regex-only\pescape was intended to address is another matter. The author of #46 should be able to provide insight into whether the existing tests cover those issues.