setup.py: Read version from __init__.py to avoid importing the module - #55
Merged
Conversation
The module import happens before setup() is executed, and therefore, none of the modules specified in 'setup_requires' (or 'install_requires', for that matter) are loaded at that moment, causing the import to fail with ModuleNotFoundError. Following the first recommendation from the 'Single-sourcing the package version' section of the Python Package User Guide [1], in this commit we switch to reading the version string from the '__init__.py' file instead of attempting to import the module. [1]: https://packaging.python.org/guides/single-sourcing-package-version/ --- Also includes updates in patch at #54 (comment)
Owner
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module import happens before setup() is executed, and therefore,
none of the modules specified in 'setup_requires' (or 'install_requires',
for that matter) are loaded at that moment, causing the import to fail
with ModuleNotFoundError.
Following the first recommendation from the 'Single-sourcing the
package version' section of the Python Package User Guide 1, in this
commit we switch to reading the version string from the 'init.py'
file instead of attempting to import the module.
Also includes updates in patch at
#54 (comment)