More robust against unicode chars - #28
Merged
Merged
Conversation
Garrett-R
commented
Jul 14, 2017
| from titlecase import ALL_CAPS | ||
| assert bool(ALL_CAPS.match('THIS IS ALL CAPS')) is True | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
This test is now irrelevant.
Owner
|
Looks good to me, thanks! |
ppannuto
added a commit
that referenced
this pull request
Jul 15, 2017
* #27 Improved README from @adamchainz * #28 Improved handling of unicode from @Garrett-R * #29 Fix for py2k/3k unicode compatibility from @lucaswiman Thanks to all who helped contribute!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this approach is more robust.