move ruby discovery code into a function#493
Open
kbrock wants to merge 1 commit intopostmodern:masterfrom
Open
move ruby discovery code into a function#493kbrock wants to merge 1 commit intopostmodern:masterfrom
kbrock wants to merge 1 commit intopostmodern:masterfrom
Conversation
postmodern
requested changes
Apr 26, 2023
Owner
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Spotted a few stylistic things.
| { | ||
| RUBIES=() | ||
| local dir | ||
| for dir in "$PREFIX/opt/rubies" "$HOME/.rubies"; do |
Owner
There was a problem hiding this comment.
Shell script must be hard-tab indented.
share/chruby/chruby.sh
Outdated
| done | ||
| } | ||
|
|
||
| chruby_discover |
Owner
There was a problem hiding this comment.
I tend to put any non-function code at the end of the file.
Owner
|
Since you're adding a new function, I would technically need to merge this into the 0.4.0 branch. |
When you install a new ruby in a different terminal shell, chruby does not pick up on the new ruby version. The solution is to to source chruby.sh again. Introducing chruby_discover which will allow any shell to pick up on the new ruby versions
Contributor
Author
|
Fixed. Thanks for the feedback. I forgot all about tabs. It is ok if you don't want to go this route and bump the major version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you install a new ruby in a different terminal shell, chruby does not pick up on the new ruby version.
The solution is to to source chruby.sh again.
Introducing chruby_discover which will allow any shell to pick up on the new ruby versions
Yes, I was trying to "optimize" this functionality in #492 - but this PR is not an optimization play.
I have had this function defined in my bashrc for a while and thought others may want it as well.