Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT

petere · petere · commit ce13bb96fbcc · 2025-08-06T10:58:06.000+02:00
These were introduced (commit efdc7d7) at the same time as we were moving to using the standard inttypes.h format macros (commit a0ed19e). It doesn't seem useful to keep a new already-deprecated interface like this with only a few users, so remove the new symbols again and have the callers use PRIx64. (Also, INT64_HEX_FORMAT was kind of a misnomer, since hex formats all use unsigned types.) Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/0ac47b5d-e5ab-4cac-98a7-bdee0e2831e4%40eisentraut.org
diff --git a/contrib/postgres_fdw/option.c b/contrib/postgres_fdw/option.c
@@ -531,7 +531,7 @@ process_pgfdw_appname(const char *appname)
 				appendStringInfoString(&buf, application_name);
 				break;
 			case 'c':
-				appendStringInfo(&buf, INT64_HEX_FORMAT ".%x", MyStartTime, MyProcPid);
+				appendStringInfo(&buf, "%" PRIx64 ".%x", MyStartTime, MyProcPid);
 				break;
 			case 'C':
 				appendStringInfoString(&buf, cluster_name);
diff --git a/src/backend/utils/error/csvlog.c b/src/backend/utils/error/csvlog.c
@@ -120,7 +120,7 @@ write_csvlog(ErrorData *edata)
 	appendStringInfoChar(&buf, ',');
 
 	/* session id */
-	appendStringInfo(&buf, INT64_HEX_FORMAT ".%x", MyStartTime, MyProcPid);
+	appendStringInfo(&buf, "%" PRIx64 ".%x", MyStartTime, MyProcPid);
 	appendStringInfoChar(&buf, ',');
 
 	/* Line number */
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
@@ -2956,12 +2956,12 @@ log_status_format(StringInfo buf, const char *format, ErrorData *edata)
 				{
 					char		strfbuf[128];
 
-					snprintf(strfbuf, sizeof(strfbuf) - 1, INT64_HEX_FORMAT ".%x",
+					snprintf(strfbuf, sizeof(strfbuf) - 1, "%" PRIx64 ".%x",
 							 MyStartTime, MyProcPid);
 					appendStringInfo(buf, "%*s", padding, strfbuf);
 				}
 				else
-					appendStringInfo(buf, INT64_HEX_FORMAT ".%x", MyStartTime, MyProcPid);
+					appendStringInfo(buf, "%" PRIx64 ".%x", MyStartTime, MyProcPid);
 				break;
 			case 'p':
 				if (padding != 0)
diff --git a/src/backend/utils/error/jsonlog.c b/src/backend/utils/error/jsonlog.c
@@ -168,7 +168,7 @@ write_jsonlog(ErrorData *edata)
 	}
 
 	/* Session id */
-	appendJSONKeyValueFmt(&buf, "session_id", true, INT64_HEX_FORMAT ".%x",
+	appendJSONKeyValueFmt(&buf, "session_id", true, "%" PRIx64 ".%x",
 						  MyStartTime, MyProcPid);
 
 	/* Line number */
diff --git a/src/include/c.h b/src/include/c.h
@@ -519,8 +519,6 @@ typedef uint32 bits32;			/* >= 32 bits */
 /* snprintf format strings to use for 64-bit integers */
 #define INT64_FORMAT "%" PRId64
 #define UINT64_FORMAT "%" PRIu64
-#define INT64_HEX_FORMAT "%" PRIx64
-#define UINT64_HEX_FORMAT "%" PRIx64
 
 /*
  * 128-bit signed and unsigned integers
diff --git a/src/test/modules/test_radixtree/test_radixtree.c b/src/test/modules/test_radixtree/test_radixtree.c
@@ -44,7 +44,7 @@
 		uint64		_expected = (expected_expr); \
 		if (_result != _expected) \
 			elog(ERROR, \
-				 "%s yielded " UINT64_HEX_FORMAT ", expected " UINT64_HEX_FORMAT " (%s) in file \"%s\" line %u", \
+				 "%s yielded %" PRIx64 ", expected %" PRIx64 " (%s) in file \"%s\" line %u", \
 				 #result_expr, _result, _expected, #expected_expr, __FILE__, __LINE__); \
 	} while (0)
 

Original file line number	Diff line number	Diff line change
`@@ -2956,12 +2956,12 @@ log_status_format(StringInfo buf, const char format, ErrorData edata)`
`2956`	`2956`	`{`
`2957`	`2957`	`char strfbuf[128];`
`2958`	`2958`
`2959`		`- snprintf(strfbuf, sizeof(strfbuf) - 1, INT64_HEX_FORMAT ".%x",`
	`2959`	`+ snprintf(strfbuf, sizeof(strfbuf) - 1, "%" PRIx64 ".%x",`
`2960`	`2960`	`MyStartTime, MyProcPid);`
`2961`	`2961`	`appendStringInfo(buf, "%*s", padding, strfbuf);`
`2962`	`2962`	`}`
`2963`	`2963`	`else`
`2964`		`- appendStringInfo(buf, INT64_HEX_FORMAT ".%x", MyStartTime, MyProcPid);`
	`2964`	`+ appendStringInfo(buf, "%" PRIx64 ".%x", MyStartTime, MyProcPid);`
`2965`	`2965`	`break;`
`2966`	`2966`	`case 'p':`
`2967`	`2967`	`if (padding != 0)`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ write_jsonlog(ErrorData *edata)`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`/* Session id */`
`171`		`- appendJSONKeyValueFmt(&buf, "session_id", true, INT64_HEX_FORMAT ".%x",`
	`171`	`+ appendJSONKeyValueFmt(&buf, "session_id", true, "%" PRIx64 ".%x",`
`172`	`172`	`MyStartTime, MyProcPid);`
`173`	`173`
`174`	`174`	`/* Line number */`