ci: Add missing "set -e" to scripts run by su.

macdice · macdice · commit c3359d1cf5e5 · 2025-11-06T14:23:08.000+13:00
If any shell command fails, the whole script should fail. To avoid future omissions, add this even for single-command scripts that use su with heredoc syntax, as they might be extended or copied-and-pasted. Extracted from a larger patch that wanted to use #error during compilation, leading to the diagnosis of this problem. Reviewed-by: Tristan Partin <tristan@partin.io> (earlier version) Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io Backpatch-through: 15
diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
@@ -76,6 +76,7 @@ task:
   # freebsd already takes longer than other platforms except for windows.
   configure_script: |
     su postgres <<-EOF
+      set -e
       ./configure \
         --enable-cassert --enable-debug --enable-tap-tests \
         --enable-nls \
@@ -181,6 +182,7 @@ task:
 
   configure_script: |
     su postgres <<-EOF
+      set -e
       ./configure \
         --enable-cassert --enable-debug --enable-tap-tests \
         --enable-nls \
@@ -198,6 +200,7 @@ task:
 
   test_world_script: |
     su postgres <<-EOF
+      set -e
       ulimit -c unlimited # default is 0
       make -s ${CHECK} ${CHECKFLAGS} -j${TEST_JOBS}
     EOF
