pg_dump: Set private_date pointer to NULL in callback

danielgustafsson · danielgustafsson · commit b669293e3432 · 2025-04-17T12:58:00.000+02:00
The end callback for ZStandard compression frees the private_data but didn't set the pointer to NULL after freeing. This is not a bug as the code is right now, since nothing is dereferencing the pointer upon returning from the callback but it is good practice to do. Author: Alexander Kuznetsov <kuznetsovam@altlinux.org> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/efaee52b-9550-44ca-8633-ea86076b3283@altlinux.org
diff --git a/src/bin/pg_dump/compress_zstd.c b/src/bin/pg_dump/compress_zstd.c
@@ -142,6 +142,7 @@ EndCompressorZstd(ArchiveHandle *AH, CompressorState *cs)
 	/* output buffer may be allocated in either mode */
 	pg_free(zstdcs->output.dst);
 	pg_free(zstdcs);
+	cs->private_data = NULL;
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ EndCompressorZstd(ArchiveHandle AH, CompressorState cs)`
`142`	`142`	`/* output buffer may be allocated in either mode */`
`143`	`143`	`pg_free(zstdcs->output.dst);`
`144`	`144`	`pg_free(zstdcs);`
	`145`	`+ cs->private_data = NULL;`
`145`	`146`	`}`
`146`	`147`
`147`	`148`	`static void`