Avoiding:

vadim4o · vadim4o · commit 8c68e07561a3 · 1996-12-14T07:54:22.000Z
cc1: warnings being treated as errors
datum.c: In function `DatumGetSize':
datum.c:57: warning: unsigned value &gt;= 0 is always 1
gmake[3]: *** [datum.o] Error 1

There was:
    if (byVal) {
        if (len &gt;= 0 &amp;&amp; len &lt;= sizeof(Datum)) {

but len has type Size (unsigned int) and so now there is:
    if (byVal) {
        if (len &lt;= sizeof(Datum)) {
            size = len;
        } else {
            elog(WARN,
                 "datumGetSize: Error: type=%ld, byVaL with len=%d",
                 (long) type, len);
        }
    } else { /*  not byValue */
diff --git a/src/backend/utils/adt/datum.c b/src/backend/utils/adt/datum.c
@@ -6,7 +6,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3 1996/11/08 05:59:41 momjian Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3.2.1 1996/12/14 07:54:22 vadim Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -54,7 +54,7 @@ datumGetSize(Datum value, Oid type, bool byVal, Size len)
     Size size = 0;
     
     if (byVal) {
-	if (len >= 0 && len <= sizeof(Datum)) {
+	if (len <= sizeof(Datum)) {
 	    size = len;
 	} else {
 	    elog(WARN,

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`*`
`7`	`7`	`*`
`8`	`8`	`* IDENTIFICATION`
`9`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3 1996/11/08 05:59:41 momjian Exp $`
	`9`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3.2.1 1996/12/14 07:54:22 vadim Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -54,7 +54,7 @@ datumGetSize(Datum value, Oid type, bool byVal, Size len)`
`54`	`54`	`Size size = 0;`
`55`	`55`
`56`	`56`	`if (byVal) {`
`57`		`- if (len >= 0 && len <= sizeof(Datum)) {`
	`57`	`+ if (len <= sizeof(Datum)) {`
`58`	`58`	`size = len;`
`59`	`59`	`} else {`
`60`	`60`	`elog(WARN,`