Clear 'xid' in dummy async notify entries written to fill up pages

hlinnaka · hlinnaka · commit 84f1bf4afa5e · 2025-11-12T21:27:11.000+02:00
Before we started to freeze async notify entries (commit 8eeb4a0), no one looked at the 'xid' on an entry with invalid 'dboid'. But now we might actually need to freeze it later. Initialize them with InvalidTransactionId to begin with, to avoid that work later. Álvaro pointed this out in review of commit 8eeb4a0, but I forgot to include this change there. Author: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://www.postgresql.org/message-id/202511071410.52ll56eyixx7@alvherre.pgsql Backpatch-through: 14
diff --git a/src/backend/commands/async.c b/src/backend/commands/async.c
@@ -1484,6 +1484,7 @@ asyncQueueAddEntries(ListCell *nextNotify)
 			 */
 			qe.length = QUEUE_PAGESIZE - offset;
 			qe.dboid = InvalidOid;
+			qe.xid = InvalidTransactionId;
 			qe.data[0] = '\0';	/* empty channel */
 			qe.data[1] = '\0';	/* empty payload */
 		}

Original file line number	Diff line number	Diff line change
`@@ -1484,6 +1484,7 @@ asyncQueueAddEntries(ListCell *nextNotify)`
`1484`	`1484`	`*/`
`1485`	`1485`	`qe.length = QUEUE_PAGESIZE - offset;`
`1486`	`1486`	`qe.dboid = InvalidOid;`
	`1487`	`+ qe.xid = InvalidTransactionId;`
`1487`	`1488`	`qe.data[0] = '\0'; /* empty channel */`
`1488`	`1489`	`qe.data[1] = '\0'; /* empty payload */`
`1489`	`1490`	`}`