jit: Fix accidentally-harmless type confusion

anarazel · anarazel · commit 5b45f7ee7946 · 2025-11-04T18:42:04.000-05:00
In 2a0faed, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13
diff --git a/src/backend/jit/llvm/llvmjit_expr.c b/src/backend/jit/llvm/llvmjit_expr.c
@@ -2065,7 +2065,7 @@ llvm_compile_expr(ExprState *state)
 					v_nullsp = l_ptr_const(nulls, l_ptr(TypeStorageBool));
 
 					/* create blocks for checking args */
-					b_checknulls = palloc(sizeof(LLVMBasicBlockRef *) * nargs);
+					b_checknulls = palloc(sizeof(LLVMBasicBlockRef) * nargs);
 					for (int argno = 0; argno < nargs; argno++)
 					{
 						b_checknulls[argno] =

Original file line number	Diff line number	Diff line change
`@@ -2065,7 +2065,7 @@ llvm_compile_expr(ExprState *state)`
`2065`	`2065`	`v_nullsp = l_ptr_const(nulls, l_ptr(TypeStorageBool));`
`2066`	`2066`
`2067`	`2067`	`/* create blocks for checking args */`
`2068`		`- b_checknulls = palloc(sizeof(LLVMBasicBlockRef ) nargs);`
	`2068`	`+ b_checknulls = palloc(sizeof(LLVMBasicBlockRef) * nargs);`
`2069`	`2069`	`for (int argno = 0; argno < nargs; argno++)`
`2070`	`2070`	`{`
`2071`	`2071`	`b_checknulls[argno] =`