Use proper type for RestoreTransactionSnapshot's PGPROC arg

hlinnaka · hlinnaka · commit 47a9f61fcafc · 2025-12-19T13:40:02.000+02:00
Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://www.postgresql.org/message-id/08cbaeb5-aaaf-47b6-9ed8-4f7455b0bc4b@iki.fi
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
@@ -1848,12 +1848,9 @@ RestoreSnapshot(char *start_address)
 
 /*
  * Install a restored snapshot as the transaction snapshot.
- *
- * The second argument is of type void * so that snapmgr.h need not include
- * the declaration for PGPROC.
  */
 void
-RestoreTransactionSnapshot(Snapshot snapshot, void *source_pgproc)
+RestoreTransactionSnapshot(Snapshot snapshot, PGPROC *source_pgproc)
 {
 	SetTransactionSnapshot(snapshot, NULL, InvalidPid, source_pgproc);
 }
diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h
@@ -120,6 +120,7 @@ extern bool HistoricSnapshotActive(void);
 extern Size EstimateSnapshotSpace(Snapshot snapshot);
 extern void SerializeSnapshot(Snapshot snapshot, char *start_address);
 extern Snapshot RestoreSnapshot(char *start_address);
-extern void RestoreTransactionSnapshot(Snapshot snapshot, void *source_pgproc);
+struct PGPROC;
+extern void RestoreTransactionSnapshot(Snapshot snapshot, struct PGPROC *source_pgproc);
 
 #endif							/* SNAPMGR_H */

Original file line number	Diff line number	Diff line change
`@@ -1848,12 +1848,9 @@ RestoreSnapshot(char *start_address)`
`1848`	`1848`
`1849`	`1849`	`/*`
`1850`	`1850`	`* Install a restored snapshot as the transaction snapshot.`
`1851`		`- *`
`1852`		`- * The second argument is of type void * so that snapmgr.h need not include`
`1853`		`- * the declaration for PGPROC.`
`1854`	`1851`	`*/`
`1855`	`1852`	`void`
`1856`		`-RestoreTransactionSnapshot(Snapshot snapshot, void *source_pgproc)`
	`1853`	`+RestoreTransactionSnapshot(Snapshot snapshot, PGPROC *source_pgproc)`
`1857`	`1854`	`{`
`1858`	`1855`	`SetTransactionSnapshot(snapshot, NULL, InvalidPid, source_pgproc);`
`1859`	`1856`	`}`