Merged
Conversation
Member
DavidGoodwin
commented
Feb 17, 2024
DavidGoodwin
commented
- minor doc improvements
- change TOTP Exceptions to be TOTP Exemptions
- add some @todo things
- try and control who can add what exemptions.
- move addAppPassword() and revokeAppPassword() into the Login class
- remove dead code (scripts/snippets/crypt.php and scripts/snippets/crypt_test.php )
- add some incomplete unit tests
Closed
|
To follow! |
Contributor
You can simply use the "Subscribe" button in the right sidebar ;-) |
|
@svenseeberg: I do not received an e-mail without a comment... I have subscribed a lot of repositories... |
…nd a boring user can only do things for themself (totp_exception stuff)
…"Exception" for user labels
DavidGoodwin
force-pushed
the
topt-app-passwords-fixes
branch
from
f6db97b to
2faa37e
Compare
Member
Author
|
(the above was just me rebasing this branch on origin/master so i can more easily see what's changed) |
Closed
Contributor
|
@DavidGoodwin can we support you with this PR? More tests? |
Member
Author
|
Hi @svenseeberg Sorry ...it's kind of dropped off my radar a bit ... I think the only thing left to fix was the query the dovecot integration example uses - 07ea084 / #802 |
…e of working - see #802
|
@DavidGoodwin: Good job, thanks! |
|
@DavidGoodwin: Thanks for your new development releases: It has been added in PostfixAdmin 4.0 Beta 1: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.