Replace list-virtual cNav_bar with shared pagination - #1093
Conversation
|
thanks @TrapoSAMA am I being old, or is there something not quite right with the pagination controls here? 
more like this ? 
|
|
Thanks, you were right: the pagination controls were outside the section they controlled, so the anchor could land on the list while leaving the controls out of context. I've moved both the top and bottom pagers inside the respective Forwards and Mailboxes cards. The existing card header and border now provide the visual grouping without adding new colors, and the existing #aliases / #mailboxes anchors return to the correct section when changing pages. I validated both pagers with populated lists on desktop and mobile, including page navigation and horizontal overflow, with no browser console errors. The focused pagination tests pass on PHP 8.4 (11 tests, 37 assertions). |
2 participants
Summary
This is the second step of #1064, following #1090.
list-virtual.php'scNav_barHTML renderer with normalized items for the sharedtemplates/_pagination.tpl#aliasesand#mailboxesanchors for the two independently rendered listsarrow-l.png,arrow-r.png, andarrow-u.pngassetsThe alphabetical ranges still come from the existing
create_page_browser()logic. This change only normalizes those ranges for the shared renderer and removes the PHP-generated table/image markup.Validation
list-virtual.tpl: cleanpage_size=20and populated alias/mailbox lists:aria-currentsearch[_]and domain propagationThe complete local suite was also exercised. The changed pagination tests passed; the remaining failures are the existing Windows/XAMPP environment-specific checks for Unix commands, DNS discovery, GD, and URL path escaping.