Fix psalm errors: update phpVersion in psalm.xml from 7.4 to 8.2 - #1001
Closed
knofte wants to merge 1 commit into
Closed
Fix psalm errors: update phpVersion in psalm.xml from 7.4 to 8.2#1001knofte wants to merge 1 commit into
knofte wants to merge 1 commit into
Conversation
psalm.xml had phpVersion="7.4" but composer.json requires PHP >=8.2. This caused psalm to fail parsing PHP 8.1+ syntax (readonly properties) in the OTPHP library, making it unable to resolve the TOTP class hierarchy and producing cascading MissingDependency/UndefinedMethod errors.
knofte
force-pushed
the
fix-psalm-totp-errors
branch
from
March 30, 2026 20:10
d2af07a to
02f195a
Compare
knofte
changed the title
Member
|
I think your robot just needs to remove the phpVersion attribute from psalm.xml. |
Contributor
Author
Haha yeah, sometimes need manual intervention to help it think better :) |
This was referenced Mar 30, 2026
Member
|
replaced with 7dc1440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 5 psalm errors that have been causing CI failures.
Root cause
psalm.xmlhadphpVersion="7.4"butcomposer.jsonrequiresphp >= 8.2. This caused psalm to fail parsing PHP 8.1+ syntax (readonlyproperties) in thespomky-labs/otphplibrary, making it unable to resolve theOTPHP\TOTPclass hierarchy and producing cascadingMissingDependency,UndefinedMethod, andPossiblyUnusedParamerrors.Fix
Update
phpVersionfrom"7.4"to"8.2"inpsalm.xmlto match the minimum PHP version incomposer.json. No suppressions needed.Result
Test plan
composer psalm— 0 errorscomposer check-format— 0 issues