Repository navigation
Exclude the "ALL" Domain for Postfix #916
Description
mysql-virtual-domains.cf:
query = SELECT domain FROM domain WHERE domain='%s' AND active=1 AND domain != 'ALL';
because someone could send a mail to your mailserver/relayserver to example.user@all
and the mail will get through reject_unauth_destination
Not a high risk of anything, because @ALL wont get forwarded probably, but anyway this "ALL" Domain shouldnt be there for postfix.
Cheers
Activity
add some domain != 'ALL' clauses into the SQL - see #916
DavidGoodwin commentedon Mar 25, 2025
Hi @Ramalama2 - Thanks - so you so like the above changeset ? 61dce87
Ramalama2 commentedon Mar 26, 2025
@DavidGoodwin Thanks David, looks good to me!
Ramalama2 commentedon Mar 26, 2025
@rincorvid Yes, its a fake domain, for Superadmin Accounts. (Admins that have access to all Domains/Alias Users)
Im not sure if there is another solution for Superadmin Accounts, im still on v5.0.2
DavidGoodwin commentedon Mar 26, 2025
@rincorvid nice spot! I'll wait for @cboltz to chip in at this point.
I'd (unsurprisingly) forgotten 41d8bca etc (given it was from 2011!).
cboltz commentedon Mar 28, 2025
The "ALL" domain is indeed very old and shouldn't be needed anymore. Well, in theory ;-)
However, surprisingly, there are a few usages in functions.inc.php left (which we should change/fix):
Ideally these functions should use AdminHandler to reduce the amount of duplicated logic.
Please also check
git grep ALLfor some more places that will need to be changed or cleaned up if we finally get rid of the ALL domain.