prevent Maximum call stack size exceeded for document#2065
Closed
romainmenke wants to merge 1 commit intopostcss:mainfrom
Closed
Conversation
Contributor
Author
|
Has been fixed downstream 🎉 |
romainmenke
deleted the
prevent-maximum-call-size-exceeded-for-document--frank-turkey-d3f48da227
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
documenttoRootnodes causesRangeError: Maximum call stack size exceededwhen converting to JSON ota-meshi/postcss-html#146postcss-htmladds a reference todocumentonrootnodes.This isn't totally unreasonable even if it isn't part of the PostCSS API.
Unfortunately this makes the references circular and breaks JSON serialization.
We could catch this here, in
postcss.But also totally fine with me to close this without change.
It is a downstream issue in
postcss-html.