Changed errant sys.argv to args parameter passed in.#47
Open
akfreed wants to merge 1 commit intopocc:masterfrom
Open
Changed errant sys.argv to args parameter passed in.#47akfreed wants to merge 1 commit intopocc:masterfrom
sys.argv to args parameter passed in.#47akfreed wants to merge 1 commit intopocc:masterfrom
Conversation
In some use cases, the args param given to the Command constructor was a filtered version of sys.argv. Command.get_added_files() was reading directly from sys.argv, circumventing this filtering.
c00ee62 to
46b5aad
Compare
Author
|
The Mac ci tests are failing due to the failure: https://github.com/akfreed/pocc-pre-commit-hooks/runs/6483498426?check_suite_focus=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #46
In some use cases, the
argsparam given to the Command constructor was an (purposely) stripped version of sys.argv. Command.get_added_files() was reading directly from sys.argv, circumventing this filtering.