Skip to content

tee plugin: reporting tee_send execution count per receiver#853

Open
strzebon wants to merge 1 commit into
pmacct:masterfrom
strzebon:tee_send-counters
Open

tee plugin: reporting tee_send execution count per receiver#853
strzebon wants to merge 1 commit into
pmacct:masterfrom
strzebon:tee_send-counters

Conversation

@strzebon
Copy link
Copy Markdown

This Pull Request introduces monitoring of how many times a message has been sent to a specific receiver by tee plugin. The counters are periodically exported to .csv file. Example structure of the file:

POOL_ID,RECEIVER_IP,RECEIVER_PORT,TEE_SENT
0,127.0.0.1,1234,28
1,127.0.0.2,1234,28 

Two new config properties were added:
tee_counters_refresh_time - time interval in seconds at which the counters are reported to file and reset (optional, default 60s)
tee_counters_path - file where counters are reported to (if not provided, counters are not reported)

Copy link
Copy Markdown
Member

@paololucente paololucente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Witold ( @strzebon ), thanks very much for this contribution.

May i ask you a couple of related questions:

  1. Can you mention a use-case for this feature? I see its usefulness but was curious how you are using it, whether manually checking the data or a 3rd party tool checks the file;

  2. Have you thought of sending this output out to the log, instead that to a specific file? Especially going through syslog, a number of options and features become available for free (including file rotation, for example). A reader could still easily filter / grep through the content; maybe in that case a JSON output (or anything self-describing) would be more favorable than CSV that needs the title to be parsed first.

Paolo

@wydrych
Copy link
Copy Markdown

wydrych commented May 27, 2025

Our idea was to keep it as similar to the print plugin as possible to keep the things generic for whoever parses the CVS anyhow :-)

  1. The use case is to have a generic monitoring framework for the tee plugin. We're forwarding samples to various destinations, sometimes with filtering. While we have metrics at each destination, monitoring the tee plugin helps identify issues at each stage.
  2. We saw it being similar to the print plugin – CSV may not be ideal, but it is generic and easy to parse or process further into other monitoring systems.

@wydrych
Copy link
Copy Markdown

wydrych commented Oct 23, 2025

Hi Paolo @paololucente,

ping :-) Do you think we could have it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants