This repository was archived by the owner on Nov 30, 2024. It is now read-only.
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
{{ ASSET_PATH }} only seems to work in _includes/theme/themename/default.html, leaves off theme name in post.html and page.html #113
Description
To reproduce:
rake theme:switch name="twitter"- add an image (foo.jpg) asset to
assets/themes/twitter/ - modify
_includes/themes/twitter/page.htmlto include the image path using the liquid variable {{ ASSET_PATH }}:
<div class="page-header">
<h1>{{ page.title }} {% if page.tagline %} <small>{{ page.tagline }}</small>{% endif %}</h1>
<img src="{{ ASSET_PATH }}/foo.jpg">
</div>
<div class="row">
<div class="span12">
{{ content }}
</div>
</div>- modify
_includes/themes/twitter/default.htmlto includefoo.jpg
<body>
<img src="{{ ASSET_PATH }}/media_markHenning.jpg">
<div class="navbar">
<div class="navbar-inner">
<div class="container">
<a class="brand" href="{{ HOME_PATH }}">{{ site.title }}</a>
<ul class="nav">-
Generate a new page using
rake page name="bar.html" -
Start Jekyll using
jekyll --server --safe -
Navigate to http://localhost:4000
Expected Result
-
foo.jpgappears above the nav bar: screenshot -
Now, navigate to http://localhost:4000
Expected Result
foo.jpgappears above the nav bar (from default.html template) as well as under the H1
Actual Result
foo.jpgappears above the nav bar (from default.html template) but shows as a broken image under the H1. screenshot. The image tag is rendered as<img src="https://github.com/assets/themes//foo.jpg">, missing the theme directory.
I can reproduce this issue on includes/themes/[any theme]/page.html and includes/themes/[any theme]/post.html.
If I manually set asset_path in _config.yml, it behaves as expected.