You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b156742
Browse filesBrowse the repository at this point in the historyBrowse files
feat(interlink): patch stage support for foreign executions (#3520)
* feat(interlink): patch stage support for foreign executions
Some operations like skip wait or manual approvals result in calls to
PATCH /pipelines/pipelineId/stages/stageId
with a context map values used to augment the designated stage context. The TaskController also updates the stage's `lastModified` field with user and account information, so that manual approval stages can be used to propagate auth info. This is all great as long as we operate on local executions, but for foreign executions (owned by a different orca cluster), we can't just patch read-only stages.
To support this, we:
- make `ExecutionRepository::storeStage` foreign-aware
- for foreign executions, we create a `PatchStageInterlinkEvent` (if supported) that contains the body of the stage
- the stage body includes the updated context map values and `lastModified` information
- we add an `updateStage` method in `CompoundExecutionOperator` and update the `TaskController` to call it
- we also call it from the event's `applyTo` method
* chore(interlink): simplify a few parts
- using stageById instead of the loop-based lookup
- use @DaTa on LastModifiedDetails
- do the time check in StageExecution::setLastModified, but only warn (i.e. be more permissive)
- adjust test behavior accordingly
* fix(interlink): do not run queue action if repo action failed
Copy file name to clipboardExpand all lines: orca/orca-interlink/src/main/java/com/netflix/spinnaker/orca/interlink/aws/InterlinkAmazonMessageHandler.java
0 commit comments