Conversation
Unified hover built the bar swatch from pattern index 0. Use the hovered point index so color and pattern match that bar. Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
The fork pull request number is now known. Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features, Bug fixes, and others
Fixes #8008.
Unified hover builds the bar swatch via the mock legend path.
styleBarLikealways readmarker.patternat index0, so whenshape/fgcolorare per-point arrays the tooltip swatch used the first bar's pattern and color.When
legend._inHoveris set, use the hovered point index instead. Hover pattern defs get a separate id so they do not overwrite the real legend.Adds a Jasmine regression covering per-point
shape/fgcolor/fgopacityunder unified hover.dist/untouched.