Skip to content

Add clustering options to scattermapbox#5827

Merged
archmoj merged 23 commits into
masterfrom
finalist-cluster-scattermapbox
Oct 14, 2022
Merged

Add clustering options to scattermapbox#5827
archmoj merged 23 commits into
masterfrom
finalist-cluster-scattermapbox

Conversation

@archmoj

@archmoj archmoj commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

Follow up for PR #5334.

Options added by @elben10 to enable mapbox clustering layer.
Please note that currently it doesn't support the fill, selection and text features.

Some remaining TODOs:

  • add jasmine tests to ensure Plotly.react can switch between modes i.e. with/without cluster
  • add second mock & baseline using new attributes e.g. step and opacity

@plotly/plotly_js

@archmoj archmoj added feature something new community community contribution status: has TODOs labels Jul 14, 2021
Comment thread src/traces/scattermapbox/attributes.js Outdated
cluster: {
enabled: {
valType: 'boolean',
dflt: false,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a smart default here? ie true if any other cluster attributes are set, otherwise false?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Done in 477d2a0.

Comment thread src/traces/scattermapbox/attributes.js Outdated
Comment thread src/traces/scattermapbox/attributes.js Outdated

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM!

@archmoj archmoj merged commit 2cc42e2 into master Oct 14, 2022
@archmoj archmoj deleted the finalist-cluster-scattermapbox branch October 14, 2022 21:00
kMutagene added a commit to plotly/Plotly.NET that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community community contribution feature something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants