Skip to content

Use probe-image-size module to read width and height of images#5388

Merged
archmoj merged 1 commit intomasterfrom
switch-to-probe-image-size
Jan 8, 2021
Merged

Use probe-image-size module to read width and height of images#5388
archmoj merged 1 commit intomasterfrom
switch-to-probe-image-size

Conversation

@archmoj
Copy link
Copy Markdown
Contributor

@archmoj archmoj commented Jan 8, 2021

Addressing #5377 (comment),
this should close #5243 and #5377 plus it may be useful for #1323.

@plotly/plotly_js
@rreusser

@archmoj archmoj added bug something broken status: reviewable labels Jan 8, 2021
@archmoj archmoj added this to the Next major milestone Jan 8, 2021
Copy link
Copy Markdown
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nice and easy 🥇

@archmoj archmoj merged commit c7e5a22 into master Jan 8, 2021
@archmoj archmoj deleted the switch-to-probe-image-size branch January 8, 2021 13:58
@archmoj archmoj mentioned this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReferenceError: document is not defined

2 participants