You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I did not find the time to read the entire the discussion, but IMHO image-size should be in dev dependencies list because, for example, image-size uses the fs module which is not available in the browsers (in my case through webpack). Maybe it is just my specific case but any help is appreciated.
What can I do if, through plotly.js, I get this error:?
BTW please feel free to open a new issue concerning your problem or alternatively submit a PR to replace image-size with another module that could return the size of an image of png, jpg, bmp and gif formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
size-imagemodule should have been moved fromdev-dependenciestodependenciesin #5075.This caused the
streambedtests to fail:https://app.circleci.com/pipelines/github/plotly/streambed/4623/workflows/a68b7b90-9b44-4ab3-909b-d0fa4ed3bd07/jobs/58431
cc: https://github.com/plotly/streambed/pull/14972
@plotly/plotly_js