Add way for toImage to export images with current graph width/height - #3746
Merged
Conversation
... where in that case, we use graph's current width/height
(as found in gd._fullLayout) for the exported dimensions.
Contributor
|
Hah that’s actually what I had initially tried and thought might work so I’m totally down with that approach. /cc @chriddyp |
Member
|
lgtm! |
Contributor
|
Beautiful feature @etpinard ! Could config options |
Contributor
Author
I'd call that a breaking change. For sure in v2 though. |
Contributor
Ok, then the only request I have is to add it to the v2 wishlist! 💃 |
Contributor
Author
✏️ in #1576 (comment) - for better context info. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3743 ... in a slightly more general way than proposed in that issue.
This PR adds special logic to
Plotly.toImage(which is called byPlotly.downloadImage, which is itself called when clicking on thetoImagemodebar button) for optionswidth:nullandheight:null.In brief,
Plotly.toImage(gd, {width:null, height:null})will use the width/height values found ingd._fullLayoutto generate its output image. Equivalently,and clicking on the
toImagemodebar button will generate an image using the currentgd._fullLayout.widthandgd._fullLayout.heightvalues - which (should at least) always store the current graph width/height values.@plotly/plotly_js @nicolaskruchten - let me know what you think!